support peek broker entry metadta #9067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Dec 27, 2020
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Dec 28, 2020
aloyszhang
added a commit
to aloyszhang/pulsar
that referenced
this pull request
Dec 28, 2020
This pull requeset adds `Commands.peekBrokerEntryMetadataIfExist` method to support peek broker entry metadata. This will be used in protocol handler KOP. Currently, when handles `FetchRequest`, KOP will 1. firset read `Entry` out of ledger 2. get offset from `Enty` for caculating next offset to read from and building `MemoryRecordsBuilder` 3. traverse every `Entry` and add each message into `MemoryRecordsBuilder` we need the `Entry` twice, first for peeking the offset and second for buiding `MemoryRecordsBuilder`. So, it's better that pulsar `Commands` can support only peek the broker entry metadata without changing the original entry content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull requeset adds
Commands.peekBrokerEntryMetadataIfExistmethod to support peek broker entry metadata.This will be used in protocol handler KOP.
Currently, when handles
FetchRequest, KOP willEntryout of ledgerEntyfor caculating next offset to read from and buildingMemoryRecordsBuilderEntryand add each message intoMemoryRecordsBuilderwe need the
Entrytwice, first for peeking the offset and second for buidingMemoryRecordsBuilder.So, it's better that pulsar
Commandscan support only peek the broker entry metadata without changing the original entry content.