set service-url required to false, service-url is not required if ena…

[dockerzhang]

Fixes #9126

Master Issue: #

Motivation

there is --url required restriction for adding cluster if TLS is enabled, here we only need the --url-secure/--broker-url-secure params

Modifications

set service-url required to false, service-url is not required if enable TLS for pulsar cluster.

Verifying this change

• Make sure that the change passes the CI checks.

[dockerzhang]

/pulsarbot run-failure-checks

[eolivelli]

please add unit tests, to demonstrate the commands that do not require this option and in order to prevent regressions.
Now that this option is no more required, what happens to the user if he does not provide this option in command that need it ? can you please also add test cases?

[sijie]

@dockerzhang Can you rebase your pull request to the latest master to include the changes fixing the broken master?

[sijie]

/pulsarbot run-failure-checks

[eolivelli]

@dockerzhang

Now that this option is no more required, what happens to the user if he does not provide this option in command that need it ?

[sijie]

@eolivelli It is the same situation when you use TLS URLs but you don't specify TLS URLs in the cluster metadata. Geo replication will fail at that time.

[eolivelli]

@sijie got it. Thanks for your clarification