Issue 9130: Pulsar-admin sinks create: bad error message "java.lang.NullPointerException: path is 'null'." in case of missing "--name" parameter #9131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ullPointerException: path is 'null'." in case of missing "--name" parameter
sijie
requested changes
Jan 5, 2021
| @@ -232,6 +233,10 @@ public void createSink(SinkConfig sinkConfig, String fileName) throws PulsarAdmi | |||
| @Override | |||
| public CompletableFuture<Void> createSinkAsync(SinkConfig sinkConfig, String fileName) { | |||
| final CompletableFuture<Void> future = new CompletableFuture<>(); | |||
| if (StringUtils.isBlank(sinkConfig.getName())) { | |||
There was a problem hiding this comment.
Don't we need a better story here to validate the parameters? For example, what if tenant or namespace is null?
There was a problem hiding this comment.
@sijie I have added validation for all of the methods in SinksImpl for sinkname, namespace and tenant.
PTAL
|
/pulsarbot rerun-failure-tests |
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Jan 7, 2021
|
/pulsarbot run-failure-checks |
|
@eolivelli Can you rebase to the latest master? |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9130
Motivation
Return a better error to the user
Modifications
Add an explicit validation and do not let WebTarget#path throw an internal error.
The validation covers tenant,namespace and sinkname in all of the functions regarding sinks.
We must do the validation here because we have to prevent code to pass bad values to JAX-RS client
Verifying this change
This change added unit tests