Additional error checks in TwoPhasesCompactor #9133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
ivankelly,
sijie,
srkukarni,
rdhabalia,
jerrypeng and
codelipenghui
jerrypeng
approved these changes
Jan 5, 2021
sijie
approved these changes
Jan 6, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jan 7, 2021
If there is an exception in the `whenComplete()` block, the exception is "eaten" up and the `loopPromise` is never set to failed. Instead, it's better to use the `thenAccept().exceptionally()` to ensure that any exception in the first handler will be propagated back. (cherry picked from commit 984bf83)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If there is an exception in the
whenComplete()block, the exception is "eaten" up and theloopPromiseis never set to failed.Instead, it's better to use the
thenAccept().exceptionally()to ensure that any exception in the first handler will be propagated back.