[C++] UnAckedMessageTracker handles batch message incorrectly #9170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see #9072 (comment) |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
@BewareMyPower Would you please also take a look of this PR? |
jiazhai
approved these changes
Jan 11, 2021
sijie
approved these changes
Jan 11, 2021
codelipenghui
approved these changes
Jan 12, 2021
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
…#9170) ### Motivation It is necessary to reset batchIndex of MessageId when tracking a message. Because only the ack of the last message in batch is removed from `UnAckedMessageTrackerEnabled` ### Verifying this change add test case: testBatchUnAckedMessageTracker() ### Modifications when track or untrack a message, reset batchIndex of MessageId to -1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is necessary to reset batchIndex of MessageId when tracking a message. Because only the ack of the last message in batch is
removed from
UnAckedMessageTrackerEnabledVerifying this change
add test case: testBatchUnAckedMessageTracker()
Modifications
when track or untrack a message, reset batchIndex of MessageId to -1
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation