PIP-45: Implement CoordinationService on top of MetadataStore #9221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
merlimat
requested review from
ivankelly,
sijie,
srkukarni,
rdhabalia,
jerrypeng and
codelipenghui
eolivelli
approved these changes
Jan 16, 2021
| } | ||
|
|
||
| @Override | ||
| public synchronized CompletableFuture<Void> updateValue(T newValue) { |
There was a problem hiding this comment.
Probably we do not need 'synchonized' here, the real critical section is executed in another thread
There was a problem hiding this comment.
We need the synchronized for reading the version field
There was a problem hiding this comment.
Right. Thanks for the clarification
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Jan 18, 2021
sijie
approved these changes
Jan 18, 2021
|
/pulsarbot run-failure-checks |
merlimat
added a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
…#9221) * PIP-45: CoordinationService * Fixed test compile * Handle concurrent write internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Added
CoordinationServiceabstraction implemented on top ofMetadataStore.CoordinationService provides: