fix un-correct tips for create topic error when namespace not exist #9223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Jan 17, 2021
|
/pulsarbot run-failure-checks |
eolivelli
reviewed
Jan 18, 2021
| @@ -321,6 +321,9 @@ protected void validateGlobalNamespaceOwnership(String property, String namespac | |||
| } catch (IllegalArgumentException e) { | |||
| throw new RestException(Status.PRECONDITION_FAILED, "Tenant name or namespace is not valid"); | |||
| } catch (RestException re) { | |||
| if (re.getResponse().getStatus() == Status.NOT_FOUND.getStatusCode()) { | |||
There was a problem hiding this comment.
thanks for providing a fix to my issue.
I am not sure I understand why we are converting all of the RestExceptions to "Namespace does not have any clusters configured"
what about 5xx errors ("Internal server error") ?
probably we should forward to PRECONDITION_FAILED only under specific circumstances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9220
Motivation
fix un-correct tips for create topic error when namespace not exist