Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support get topic applied policy for InactiveTopic #9230

Merged
merged 4 commits into from
Jan 20, 2021

Conversation

315157973
Copy link
Contributor

Master Issue: #9216

Modifications

1 Now if there is no data at the namespace-level, the broker-level data will be returned by default, so let it return null
2 add query param applied for getInactiveTopic
3 add applied API for client

Verifying this change

unit test:
InactiveTopicDeleteTest#testInactiveTopicApplied

@sijie sijie added this to the 2.8.0 milestone Jan 18, 2021
@zymap
Copy link
Member

zymap commented Jan 19, 2021

You have a style issue:

Error:  src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:[874] (sizes) LineLength: Line is longer than 120 characters (found 121).
Error:  Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (check-style) on project pulsar-broker: You have 1 Checkstyle violation. -> [Help 1]

@315157973
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@315157973
Copy link
Contributor Author

/pulsarbot run-failure-checks

# Conflicts:
#	pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java
@sijie sijie merged commit 215bd35 into apache:master Jan 20, 2021
@315157973 315157973 deleted the Inactive branch February 23, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants