[Transaction] TC end transaction retry. #9236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 12, 2021 23:40
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/TransactionMetadataStoreService.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java # pulsar-common/src/main/proto/PulsarMarkers.proto # pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java
…ransaction_op_retry
This was referenced Jan 19, 2021
| category = CATEGORY_TRANSACTION, | ||
| doc = "End transaction operation retry interval time. (unit:second)" | ||
| ) | ||
| private long endTxnOpRetryIntervalTime = 5; |
There was a problem hiding this comment.
If this is an internal retry logic in the TransactionMetadataService, we don't need to expose the configuration here.
| } else if (TxnAction.ABORT.getValue() == txnAction) { | ||
| return updateTxnStatus(txnID, TxnStatus.ABORTED, TxnStatus.ABORTING); | ||
| } else { | ||
| return FutureUtil.failedFuture(new Throwable("Unsupported txnAction " + txnAction)); |
There was a problem hiding this comment.
Why complete with Throwable? It should be a transaction exception.
Comment on lines
236
to
237
| if (e.getCause() instanceof TransactionNotFoundException | ||
| || e.getCause() instanceof InvalidTxnStatusException) { |
There was a problem hiding this comment.
It's better to create a method isRetryableException() to clearly list those exceptions that need to be retried. This will avoid stuck in an infinite retry situation.
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to retry end transaction.
implement
1.use timerTask to do this.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)