[Transaction] Fix transaction log append sync problem. #9238
+21
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
|
@congbobo184 Could you please give more details about this issue? If it is the recycling issue, I don't think a lock can fix it, the recycle operation still can get the lock first. If this is a race condition while update the state of the |
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Mar 2, 2021
mlyahmed
pushed a commit
to mlyahmed/pulsar
that referenced
this pull request
Mar 5, 2021
## Motivation When the transaction status become aborted or committed the cursor may not delete the position, if not lock transaction operation and add append log position. If the txnMetaImpl have recycle, the same time we update the txnStatus in this recycle one we will produce the error behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the transaction status become aborted or committed the cursor may not delete the position, if not lock transaction operation and add append log position.
If the txnMetaImpl have recycle, the same time we update the txnStatus in this recycle one we will produce the error behavior.
implement
Verifying this change
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)