Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functions] Fixes function worker get superuser role #9259

Merged
merged 3 commits into from
Jan 23, 2021

Conversation

zymap
Copy link
Member

@zymap zymap commented Jan 21, 2021


Fixes #7879

Motivation

Function worker should use authorization service to check
a role if a superuser.

Modifications

  • Fix the isSuperuser method in the function

Verify this change

  • Adjust the original test case to verify it

---

Fixes apache#7879

*Motivation*

Function worker should use authorization service to check
a role if a superuser.

*Modifications*

- Fix the isSuperuser method in the function

*Verify this change*

Please pick either of following options.

- Adjust the original test case to verify it
@sijie sijie added this to the 2.8.0 milestone Jan 21, 2021
@sijie sijie added area/function release/2.7.1 type/bug The PR fixed a bug or issue reported a bug labels Jan 21, 2021
@zymap zymap changed the title Fixes function worker get superuser role [Functions] Fixes function worker get superuser role Jan 21, 2021
@sijie
Copy link
Member

sijie commented Jan 21, 2021

/pulsarbot run-failure-checks

@zymap zymap merged commit d3f8440 into apache:master Jan 23, 2021
@zymap zymap deleted the fix-function-worker-superuser branch January 23, 2021 12:37
codelipenghui pushed a commit that referenced this pull request Jan 26, 2021
* Fixes function worker get superuser role
---

Fixes #7879

*Motivation*

Function worker should use authorization service to check
a role if a superuser.

*Modifications*

- Fix the isSuperuser method in the function

*Verify this change*

Please pick either of following options.

- Adjust the original test case to verify it

* Fix the tests

(cherry picked from commit d3f8440)
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Jan 26, 2021
merlimat pushed a commit to merlimat/pulsar that referenced this pull request Apr 6, 2021
* Fixes function worker get superuser role
---

Fixes apache#7879

*Motivation*

Function worker should use authorization service to check
a role if a superuser.

*Modifications*

- Fix the isSuperuser method in the function

*Verify this change*

Please pick either of following options.

- Adjust the original test case to verify it

* Fix the tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/function cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create function doesn't use AuthorizationProvider's isSuperUser method
3 participants