PIP-45: Added session events to metadata store #9273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
merlimat
requested review from
ivankelly,
sijie,
rdhabalia,
jerrypeng and
codelipenghui
merlimat
force-pushed
the
session-events
branch
from
833478b
to
02bec9e
Compare
eolivelli
approved these changes
Jan 22, 2021
| try { | ||
| l.accept(event); | ||
| } catch (Throwable t) { | ||
| log.warn("Error in processing session event", t); |
There was a problem hiding this comment.
The Consumer interface doesn't allow to throw InterruptedException and we cannot catch that directly since it's a checked exception. If the listener code does any blocking operation, it would be its responsibility to handle the InterruptedException.
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Feb 1, 2021
|
/pulsarbot run-failure-checks |
merlimat
added a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
* PIP-45: Added session events to metadata store * Added missing license header * Fixed session timeout in MockZookeeper * Increased test timeouts * Increase session timeout in ZKSessionTest * Fixed merge issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Added mechanism to send notification on the metadata store session status. This will be used to trigger lock revalidation after a session is lost and also to do best effort approach in avoiding attempting non-essential metadata operations while the client is known not to be connected.