[C++] Fix ServerError is not converted to string in log #9277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Jan 22, 2021
BewareMyPower
force-pushed
the
bewaremypower/cpp-log-fix
branch
from
6798430
to
f91ea9b
Compare
|
/pulsarbot run-failure-checks |
zymap
approved these changes
Jan 23, 2021
|
/pulsarbot run-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9211
Motivation
In some code of C++ client, the protobuf generated
ServerErroris passed toLOG_XXXdirectly, so the logs only contain the enum integer value but not the description string. This PR is to fix it for more readable logs.Modifications
The
ClientConnection.ccalready provides agetResultfunction for convertingServerErrortoResult, but some references ofServerErrordon't call the function. So this PR overridesoperator<<forServerErrorand convert it toResultinLOG_XXXmacros that usestd::stringstream::operator<<to serialize variables to string.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.