Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bookkeeper shell more userfriendly #9281

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

eolivelli
Copy link
Contributor

BookKeeper shell is not writing the output to the Console, this makes the tool pretty useless for command line users.

With this change we will have the same result as in the standard "bookkeeper shell" tool bundled with Apache BookKeeper

Changes:

  • remove "JMX is enabled by default": it is only annoying
  • set Console as Appender in case of "shell" execution

@eolivelli
Copy link
Contributor Author

/pulsarbot run-failure-checks

@rdhabalia
Copy link
Contributor

/pulsarbot run-failure-checks

@sijie sijie added this to the 2.8.0 milestone Jan 23, 2021
@sijie sijie added area/tool type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Jan 23, 2021
@eolivelli
Copy link
Contributor Author

/pulsarbot run-failure-checks

@eolivelli
Copy link
Contributor Author

This patch is good to be merged

@merlimat merlimat merged commit 25dbc94 into apache:master Jan 26, 2021
merlimat pushed a commit to merlimat/pulsar that referenced this pull request Apr 6, 2021
Co-authored-by: Enrico Olivelli <eolivelli@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tool type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants