Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support get topic applied policy for DeduplicationStatus #9339

Merged
merged 9 commits into from
Mar 1, 2021

Conversation

315157973
Copy link
Contributor

Master Issue: #9216

Modifications

  1. The api name of topic-level is consistent with that of namespace-level
  2. Fix the problem that the namespace-level policy cannot be removed
  3. Fix the problem that topic-level does not take effect when multiple levels of policy are set at the same time
  4. Added applied API

Verifying this change

Verify that the new API is correct
Verify that the applied API is correct
Verify that policies of different levels exist at the same time and whether the priority is correct

@315157973 315157973 changed the title Deduplication Support get topic applied policy for DeduplicationStatus Jan 27, 2021
@sijie sijie requested review from sijie, codelipenghui, hangc0276, jiazhai, merlimat and zymap and removed request for sijie January 27, 2021 07:44
@sijie sijie added this to the 2.8.0 milestone Jan 27, 2021
@sijie
Copy link
Member

sijie commented Feb 8, 2021

@zymap Can you review it again?

Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, could you please rebase the master branch?

Copy link
Member

@zymap zymap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui merged commit 74db656 into apache:master Mar 1, 2021
@315157973 315157973 deleted the Deduplication branch March 12, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants