Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[broker] Support networkTopologyScriptFileName for ScriptBasedMapping #9363

Merged
merged 2 commits into from
Jan 30, 2021
Merged

[broker] Support networkTopologyScriptFileName for ScriptBasedMapping #9363

merged 2 commits into from
Jan 30, 2021

Conversation

hrsakai
Copy link
Contributor

@hrsakai hrsakai commented Jan 29, 2021

Motivation

  • We want to use org.apache.bookkeeper.net.ScriptBasedMapping for reppDnsResolverClass, but it require networkTopologyScriptFileName.

Modifications

  • Support networkTopologyScriptFileName in broker conf.

@hrsakai hrsakai added this to the 2.8.0 milestone Jan 29, 2021
@hrsakai hrsakai self-assigned this Jan 29, 2021
@hrsakai
Copy link
Contributor Author

hrsakai commented Jan 30, 2021

/pulsarbot run-failure-checks

2 similar comments
@hrsakai
Copy link
Contributor Author

hrsakai commented Jan 30, 2021

/pulsarbot run-failure-checks

@hrsakai
Copy link
Contributor Author

hrsakai commented Jan 30, 2021

/pulsarbot run-failure-checks

@Renkai
Copy link
Contributor

Renkai commented Jan 30, 2021

@hrsakai please merge the newest master and rerun tests.

@hrsakai
Copy link
Contributor Author

hrsakai commented Jan 30, 2021

@Renkai
I see. Thanks.

@hrsakai
Copy link
Contributor Author

hrsakai commented Jan 30, 2021

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 8a8e285 into apache:master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@hrsakai hrsakai

Labels
area/broker
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hrsakai @Renkai @sijie @codelipenghui