[fix #9315] Add downloadDirectory support to function k8s runtime #9377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeznet
force-pushed
the
freeznet/fix-downloadDirectory-not-applied-to-k8s-runtime
branch
2 times, most recently
from
69ff4ce
to
10dc0bd
Compare
freeznet
changed the title
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Feb 1, 2021
|
@nlu90 Can you review this pull request? |
freeznet
force-pushed
the
freeznet/fix-downloadDirectory-not-applied-to-k8s-runtime
branch
from
10dc0bd
to
992aa0e
Compare
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
klwilson227
approved these changes
Feb 2, 2021
|
/pulsarbot run-failure-checks |
4 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
freeznet
force-pushed
the
freeznet/fix-downloadDirectory-not-applied-to-k8s-runtime
branch
from
3c7d0cf
to
e907cc0
Compare
|
/pulsarbot run-failure-checks |
nlu90
reviewed
Feb 4, 2021
.../runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java
Outdated
Show resolved
Hide resolved
nlu90
approved these changes
Feb 4, 2021
freeznet
force-pushed
the
freeznet/fix-downloadDirectory-not-applied-to-k8s-runtime
branch
2 times, most recently
from
f6afec5
to
ab8ef03
Compare
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Feb 5, 2021
|
/pulsarbot run-failure-checks |
freeznet
force-pushed
the
freeznet/fix-downloadDirectory-not-applied-to-k8s-runtime
branch
from
30e5ac0
to
2fa7434
Compare
freeznet
force-pushed
the
freeznet/fix-downloadDirectory-not-applied-to-k8s-runtime
branch
from
d568a44
to
a3a8406
Compare
|
/pulsarbot run-failure-checks |
zymap
approved these changes
Feb 9, 2021
|
@freeznet Could you help push a PR based on branch-2.7? |
freeznet
added a commit
to freeznet/pulsar
that referenced
this pull request
Feb 19, 2021
…me (apache#9377) Fixes apache#9315 ### Motivation k8s runtime not using `downloadDirectory` defined from `functions_worker.yml`, so user cannot self define the download directory for k8s runtime. ### Modifications - add `downloadDirectory` from `WorkerConfig` - add backward compatibles - add tests ### Verifying this change - [x] Make sure that the change passes the CI checks. # Conflicts: # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PackagesImpl.java # pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeTest.java
@codelipenghui I have created a new pr #9619, PTAL, thanks. |
freeznet
added a commit
to freeznet/pulsar
that referenced
this pull request
Feb 22, 2021
…me (apache#9377) Fixes apache#9315 ### Motivation k8s runtime not using `downloadDirectory` defined from `functions_worker.yml`, so user cannot self define the download directory for k8s runtime. ### Modifications - add `downloadDirectory` from `WorkerConfig` - add backward compatibles - add tests ### Verifying this change - [x] Make sure that the change passes the CI checks. # Conflicts: # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PackagesImpl.java # pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeTest.java
codelipenghui
pushed a commit
that referenced
this pull request
Feb 22, 2021
…9619) Fixes #9315 ### Motivation per request from @codelipenghui in #9377, this pr is cherry pick #9377 to branch 2.7 and resolved conflicts. ### Modifications - cherry pick pr - resolve conflicts in tests - remove `package` related code
|
We have another PR for fixing this issue on branch 2.7. So I will remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9315
Motivation
k8s runtime not using
downloadDirectorydefined fromfunctions_worker.yml, so user cannot self define the download directory for k8s runtime.Modifications
downloadDirectoryfromWorkerConfigVerifying this change