[client] Add default implementation of CryptoKeyReader #9379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massakam
added
type/enhancement
sijie
approved these changes
Feb 1, 2021
sijie
pushed a commit
that referenced
this pull request
Feb 24, 2021
Currently, `pulsar-perf` has its own implementation class of `CryptoKeyReader` for end-to-end encryption of messages. Instead of this class, use `DefaultCryptoKeyReader` implemented in #9379. This change allows us to specify public and private keys by data URI as well as by file path.
zymap
pushed a commit
that referenced
this pull request
Mar 3, 2021
Currently, `pulsar-perf` has its own implementation class of `CryptoKeyReader` for end-to-end encryption of messages. Instead of this class, use `DefaultCryptoKeyReader` implemented in #9379. This change allows us to specify public and private keys by data URI as well as by file path. (cherry picked from commit aa63511)
zymap
pushed a commit
that referenced
this pull request
Mar 3, 2021
Currently, users must implement the `CryptoKeyReader` interface for end-to-end message encryption in Java. I thought it would be useful to have a default implementation, so I added `DefaultCryptoKeyReader`.
How to use:
```java
Producer<byte[]> producer = pulsarClient.newProducer()
.topic("persistent://public/default/test")
.addEncryptionKey("my-app-key1")
.defaultCryptoKeyReader("file:///path/to/public.key")
.create();
Consumer<byte[]> consumer = pulsarClient.newConsumer()
.topic("persistent://public/default/test")
.subscriptionName("sub1")
.defaultCryptoKeyReader(new HashMap<String, String>() {
{
put("my-app-key1", "file:///path/to/private.key");
put("my-app-key2", "data:application/x-pem-file;base64,*****");
}
})
.subscribe();
```
(cherry picked from commit 85b1c7e)
zymap
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Mar 5, 2021
…che#9668) Currently, `pulsar-perf` has its own implementation class of `CryptoKeyReader` for end-to-end encryption of messages. Instead of this class, use `DefaultCryptoKeyReader` implemented in apache#9379. This change allows us to specify public and private keys by data URI as well as by file path. (cherry picked from commit aa63511)
zymap
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Mar 5, 2021
Currently, users must implement the `CryptoKeyReader` interface for end-to-end message encryption in Java. I thought it would be useful to have a default implementation, so I added `DefaultCryptoKeyReader`.
How to use:
```java
Producer<byte[]> producer = pulsarClient.newProducer()
.topic("persistent://public/default/test")
.addEncryptionKey("my-app-key1")
.defaultCryptoKeyReader("file:///path/to/public.key")
.create();
Consumer<byte[]> consumer = pulsarClient.newConsumer()
.topic("persistent://public/default/test")
.subscriptionName("sub1")
.defaultCryptoKeyReader(new HashMap<String, String>() {
{
put("my-app-key1", "file:///path/to/private.key");
put("my-app-key2", "data:application/x-pem-file;base64,*****");
}
})
.subscribe();
```
(cherry picked from commit 85b1c7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, users must implement the
CryptoKeyReaderinterface for end-to-end message encryption in Java. I thought it would be useful to have a default implementation, so I addedDefaultCryptoKeyReader.How to use: