Fix setting backlogQuota will always succeed #9382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Jan 31, 2021
zymap
reviewed
Feb 1, 2021
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java
Outdated
Show resolved
Hide resolved
zymap
reviewed
Feb 1, 2021
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java
Show resolved
Hide resolved
sijie
approved these changes
Feb 1, 2021
|
@zymap Can you review it again? If you are good with that, I think it is ready to merge. |
codelipenghui
pushed a commit
that referenced
this pull request
Feb 4, 2021
Since SetBacklogQuota does not have a return, it can actually be updated successfully even if there is a check error. (cherry picked from commit ebd70de)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since SetBacklogQuota does not have a return, it can actually be updated successfully even if there is a check error.