[Java Client] Batch version of acknowledgeAsync will return a completed future before individual messages complete #9383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Feb 1, 2021
sijie
changed the title
eolivelli
approved these changes
Feb 1, 2021
| return CompletableFuture.completedFuture(null); | ||
| List<MessageId> messageIds = new ArrayList<>(); | ||
| messages.forEach(message -> messageIds.add(message.getMessageId())); | ||
| CompletableFuture<Void> completableFuture = acknowledgeAsync(messageIds); |
There was a problem hiding this comment.
nit: you can save declaring this variable
jiazhai
approved these changes
Feb 1, 2021
added 2 commits
February 2, 2021 13:47
…d, so the test will be block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #9344
Verifying this change
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)