-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial python 3.9 client wheel build support #9389
Conversation
In a clean environment, this script can incorrectly fail in two places: * Add `-r` to xargs to avoid running command if find doesn't return anything * Add `-f` to rm to silent to avoid failure if nothing to rm
* Wrong var name `IMAGE` instead of `IMAGE_NAME` * Added python 3.9 version
* Added py39 versions to remaining build scripts * Also for cmake, updated `pulsar-client-cpp/python/CMakeLists.txt`
Hi, @BewareMyPower could you please take a look at this? |
/pulsar-bot run-failure-tests |
@vkvm thanks for the work. would you please help open a new issue to track the later change for the document? |
Added python 3.9 support to `pulsar-client-cpp/docker/push-images.sh` Presumably this is used by someone with push access to the `apachepulsar` docker registry, so it's not something I've actually tested.
Hi @vkvm, is there any chance that you could revisit this PR for doc updates? |
@momo-jun I think we don't need the doc updates now. These wheels should only be built by GitHub Actions now. |
@BewareMyPower Thanks for your information. Good to know that! I will refresh the doc status label. |
build-client-lib-within-docker.sh
build-client-lib.sh
and add py39Motivation
A python 3.9 client wheel is missing. This is an initial attempt to add it. I'm mainly concerned about Fedora + RHEL7.
Modifications
Mostly just fixing up / modifying build scripts used with docker.
I don't know enough about the build system. I made sufficient changes for me to
be able to do this (roughly):
When I built the wheel on my laptop, I commented out all other versions or
specified just 3.9.
TODO: Documentation
As a new user, it was confusing figuring out how exactly to build this. I can take a quick stab at doc updates after this is merged.