-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[client] Cleanup consumer on multitopic subscribe failure #9419
Merged
merlimat
merged 2 commits into
apache:master
from
streamnative:cleanup_failed_subscribe
Feb 12, 2021
Merged
[client] Cleanup consumer on multitopic subscribe failure #9419
merlimat
merged 2 commits into
apache:master
from
streamnative:cleanup_failed_subscribe
Feb 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when a multi-topic subscribe fails (via a set of topics or a regex) we can leave consumers connected, as the multitopic consumer doesn't close any of the topics. This means we rely on the client to call closeAsync, otherwise, the consumer is left in partially open state. This fix changes that, and ensures we call close in the case of an exception
zymap
approved these changes
Feb 2, 2021
codelipenghui
approved these changes
Feb 2, 2021
sijie
approved these changes
Feb 2, 2021
Failing tests record: integration sql:
broker group 1:
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Feb 3, 2021
merlimat
approved these changes
Feb 12, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Feb 18, 2021
Currently, when a multi-topic subscribe fails (via a set of topics or a regex) we can leave consumers connected, as the multitopic consumer doesn't close any of the topics. This means we rely on the client to call closeAsync, otherwise, the consumer is left in partially open state. This fix changes that, and ensures we call close in the case of an exception Co-authored-by: Sijie Guo <sijie@apache.org> (cherry picked from commit cbe9816)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/client
cherry-picked/branch-2.7
Archived: 2.7 is end of life
release/2.7.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when a multi-topic subscribe fails (via a set of topics or a
regex) we can leave consumers connected, as the multitopic consumer
doesn't close any of the topics.
This means we rely on the client to call closeAsync, otherwise, the
consumer is left in partially open state.
Modifications
This fix changes that, and ensures we call close in the case of an
exception
Verifying this change
This change added tests that ensure that the expected methods are called in the event of subscribe failure