[pulsar-functions] enhance kubernetes manifest customizer with default options #9445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeznet
changed the title
sijie
approved these changes
Feb 3, 2021
nlu90
reviewed
Feb 4, 2021
...e/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
Outdated
Show resolved
Hide resolved
|
LGTM except the above comment for importing |
nlu90
approved these changes
Feb 4, 2021
jiazhai
approved these changes
Feb 4, 2021
freeznet
force-pushed
the
freeznet/enhance-KubernetesManifestCustomizer-with-default-options
branch
from
30bd536
to
390f850
Compare
nlu90
approved these changes
Feb 4, 2021
freeznet
force-pushed
the
freeznet/enhance-KubernetesManifestCustomizer-with-default-options
branch
from
390f850
to
66afd5e
Compare
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
Anonymitaet
added
the
doc-required
Anonymitaet
removed
the
doc-required
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
…t options (apache#9445) ### Motivation The KubernetesManifestCustomizer was introduced by customizing the stateful set of running Pulsar Functions. but no default value was loaded from `functions_worker.yaml`. ### Modifications Add load default runtime options in `BasicKubernetesManifestCustomizer` Add unit tests ### Verifying this change - [ ] Make sure that the change passes the CI checks.
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 7, 2021
…t options (apache#9445) The KubernetesManifestCustomizer was introduced by customizing the stateful set of running Pulsar Functions. but no default value was loaded from `functions_worker.yaml`. Add load default runtime options in `BasicKubernetesManifestCustomizer` Add unit tests - [ ] Make sure that the change passes the CI checks.
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 7, 2021
…t options (apache#9445) The KubernetesManifestCustomizer was introduced by customizing the stateful set of running Pulsar Functions. but no default value was loaded from `functions_worker.yaml`. Add load default runtime options in `BasicKubernetesManifestCustomizer` Add unit tests - [ ] Make sure that the change passes the CI checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The KubernetesManifestCustomizer was introduced by customizing the stateful set of running Pulsar Functions. but no default value was loaded from
functions_worker.yaml.Modifications
Add load default runtime options in
BasicKubernetesManifestCustomizerAdd unit tests
Verifying this change