Fixed NPE and cache invalidation in leader election #9460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahmed-se
approved these changes
Feb 3, 2021
lhotari
approved these changes
Feb 4, 2021
|
/pulsarbot run-failure-checks |
freeznet
approved these changes
Feb 4, 2021
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since we're relying on the watch to invalidate the cache, if another broker becomes leader we're trying in a loop to read and write based on an outdated version of metadata, until the watch arrives. Instead, since we already know that the cache is out of sync, we should proactively invalidate it.