Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception when get optional field for PB message #9468

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Fix exception when get optional field for PB message #9468

merged 1 commit into from
Feb 5, 2021

Conversation

aloyszhang
Copy link
Contributor

Fixes #9467

Motivation

This PR fixes exception when get optional field for PB message

Modifications

Before get the optional field, check does the field exist first.

sijie
sijie approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the exceptions are only thrown when debug level is enabled. I guess it is difficult to add a test case which is fine.

The change looks good to me.

@sijie sijie added this to the 2.8.0 milestone Feb 4, 2021
@sijie sijie added area/broker type/bug The PR fixed a bug or issue reported a bug labels Feb 4, 2021
@aloyszhang
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@aloyszhang
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit c6ab123 into apache:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie sijie approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@aloyszhang aloyszhang

Labels
area/broker type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Exceptions when get optional field of protobuf Message
4 participants
@aloyszhang @merlimat @sijie @codelipenghui