[Issue 9480][pulsar-io] add option for auto.offset.reset to kafka source #9482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbourkeostk
commented
Feb 4, 2021
|
@BewareMyPower Could you have a look? |
codelipenghui
approved these changes
Feb 4, 2021
codelipenghui
requested review from
Anonymitaet,
merlimat,
sijie,
315157973,
hangc0276,
jiazhai and
zymap
BewareMyPower
requested changes
Feb 4, 2021
codelipenghui
added
release/2.7.1
type/enhancement
|
Sample config added to kafkaSourceConfig.yaml and verified in loadFromYamlFileTest |
BewareMyPower
approved these changes
Feb 5, 2021
Anonymitaet
reviewed
Feb 5, 2021
sijie
approved these changes
Feb 5, 2021
Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
Anonymitaet
approved these changes
Feb 5, 2021
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
315157973
approved these changes
Feb 8, 2021
jiazhai
approved these changes
Feb 12, 2021
|
/pulsarbot rerun-failure-checks |
1 similar comment
|
/pulsarbot rerun-failure-checks |
codelipenghui
pushed a commit
that referenced
this pull request
Feb 18, 2021
…rce (#9482) Fixes #9480 ### Motivation The kafka source sets auto.offset.reset to "earliest". This means all old messages from kafka are produced to pulsar. Often is it desirable to start form the present location "latest". The option is set after the user config has been loaded so it cannot be changed: [source code link](https://github.com/apache/pulsar/blob/master/pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaAbstractSource.java#L87) ### Modifications Added an autoOffsetReset option to KafkaSourceConfig (cherry picked from commit 9c2b081)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9480
Motivation
The kafka source sets auto.offset.reset to "earliest". This means all old messages from kafka are produced to pulsar. Often is it desirable to start form the present location "latest".
The option is set after the user config has been loaded so it cannot be changed:
source code link
Modifications
Added an autoOffsetReset option to KafkaSourceConfig
Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
Added to unit test and verified behaviour.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation