[Issue 9496] fix logic in ManagedLedgerWriter when config threadNum >= ledgerNum #9497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix logic in ManagedLedgerWriter when config threadNum >= ledgerNum
merlimat
approved these changes
Feb 6, 2021
sijie
approved these changes
Feb 7, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Feb 18, 2021
…= ledgerNum (#9497) Fix #9496 fix logic in ManagedLedgerWriter when config threadNum >= ledgerNum ### Modifications if threadNum >= ledgerNum. allocate ledger repeat among threads. origin logic may have thread without ledger and got an exception. ### Verifying this change build and run `./pulsar-perf managed-ledger -e 3 -w 2 -o 10000 --threads 20 -r 100000 -s 2048 -zk localhost:2181` no exception in stdlog ### Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? (not applicable) (cherry picked from commit 07f3509)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9496
fix logic in ManagedLedgerWriter when config threadNum >= ledgerNum
Modifications
if threadNum >= ledgerNum.
allocate ledger repeat among threads.
origin logic may have thread without ledger and got an exception.
Verifying this change
build and run
./pulsar-perf managed-ledger -e 3 -w 2 -o 10000 --threads 20 -r 100000 -s 2048 -zk localhost:2181no exception in stdlog
Documentation