Optimize built-in source/sink startup Part 2 #9500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2021 11:37
…packing and checksum calculation Part 2. Allow ThreadRuntime to used cached built-in connectors instead of unpacking and loading again.
eolivelli
approved these changes
Feb 6, 2021
| fnCache.unregisterFunctionInstance( | ||
| instanceConfig.getFunctionId(), | ||
| instanceConfig.getInstanceName()); | ||
| log.info("Unloading JAR files for function {}", instanceConfig); |
There was a problem hiding this comment.
Do we have to move this line one line above?
merlimat
approved these changes
Feb 6, 2021
|
LGTM +1 |
nlu90
approved these changes
Feb 8, 2021
Comment on lines
+148
to
+151
| fnClassLoader = fnCache.getClassLoader(instanceConfig.getFunctionId()); | ||
| if (null == fnClassLoader) { | ||
| throw new Exception("No function class loader available."); | ||
| } |
There was a problem hiding this comment.
should this null check goes before the log.info on line 145 to avoid confusion?
There was a problem hiding this comment.
That is the existing logic. I rather not change it in this PR. It is kind of out of scope.
|
Great! Thanks |
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
* Optimize built-in source/sink startup by eliminating redundant NAR unpacking and checksum calculation Part 2. Allow ThreadRuntime to used cached built-in connectors instead of unpacking and loading again. Co-authored-by: Jerry Peng <jerryp@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a follow up to #9413. Allow the ThreadRuntime to leverage the already loaded and cached built-in connector registry so that it does not need to unpack NARs and calculate MD5 checksums as well.
Modifications