[Broker] Async read entries with max size bytes #9532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies with max size bytes.
merlimat
added
the
type/enhancement
merlimat
approved these changes
Feb 8, 2021
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Feb 9, 2021
eolivelli
approved these changes
Feb 9, 2021
| @Test(timeOut = 20000) | ||
| void testAsyncReadWithMaxSizeByte() throws Exception { | ||
| ManagedLedger ledger = factory.open("testAsyncReadWithMaxSizeByte"); | ||
| ManagedCursor cursor = ledger.openCursor("c1"); |
There was a problem hiding this comment.
we aren't closing this resources.
Do you think we can add @cleanup annotations in this file in all of the tests ?
(not blocker for me)
There was a problem hiding this comment.
That's ok in these tests, the factory gets re-created after each test and it automatically closes everything in the shutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, we could specify the param
maxSizeByteswhen reading entries by the methodasyncReadEntriesOrWait, but this method will be blocked when there are no entries to read. So I want to add a new method to read entries with parammaxSizeBytesand return data immediately if there are no entries to read.Modifications
asyncReadEntries(int numberOfEntriesToRead, long maxSizeBytes, ReadEntriesCallback callback, Object ctx, PositionImpl maxPosition)in the interfaceManagedCursor.asyncReadEntries(int numberOfEntriesToRead, long maxSizeBytes, ReadEntriesCallback callback, Object ctx, PositionImpl maxPosition)in the interfaceReadOnlyCursor.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changes