[C++] Removed usages of boost::regex #9533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/enhancement
merlimat
requested review from
srkukarni,
rdhabalia,
jerrypeng and
codelipenghui
aahmed-se
approved these changes
Feb 8, 2021
|
@BewareMyPower Would you please also help review this PR? |
jiazhai
approved these changes
Feb 9, 2021
sijie
approved these changes
Feb 9, 2021
|
/pulsarbot run-failure-checks |
merlimat
added a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
* [C++] Removed usages of boost::regex * Fixed formatting * Fixed test * Fixed formatting
1 task
1 task
sijie
pushed a commit
that referenced
this pull request
Jul 19, 2021
### Motivation #9533 causes some degraded behaviors at [ZTSClient](https://github.com/apache/pulsar/pull/9533/files#diff-41a90a5ec7937b5e2151752843621d6acfe8963077dc04c285842a09a4e45ecc). 1. when using boost::regex - can't set `path` at file scheme 2. when using std::regex - can't set relative path like `file:./path/to/private.key` I'd like to fix this issue. ### Modifications * Use same regex code between boost and std like [this](https://github.com/apache/pulsar/pull/9533/files#diff-a67e917f5f42f3337507a69a4e0f13e286238dc759b4048cb5141290cf445b38) * Fix regex to be able to capture relative path like `file:./`
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Jul 22, 2021
### Motivation apache#9533 causes some degraded behaviors at [ZTSClient](https://github.com/apache/pulsar/pull/9533/files#diff-41a90a5ec7937b5e2151752843621d6acfe8963077dc04c285842a09a4e45ecc). 1. when using boost::regex - can't set `path` at file scheme 2. when using std::regex - can't set relative path like `file:./path/to/private.key` I'd like to fix this issue. ### Modifications * Use same regex code between boost and std like [this](https://github.com/apache/pulsar/pull/9533/files#diff-a67e917f5f42f3337507a69a4e0f13e286238dc759b4048cb5141290cf445b38) * Fix regex to be able to capture relative path like `file:./`
codelipenghui
pushed a commit
that referenced
this pull request
Jul 23, 2021
### Motivation #9533 causes some degraded behaviors at [ZTSClient](https://github.com/apache/pulsar/pull/9533/files#diff-41a90a5ec7937b5e2151752843621d6acfe8963077dc04c285842a09a4e45ecc). 1. when using boost::regex - can't set `path` at file scheme 2. when using std::regex - can't set relative path like `file:./path/to/private.key` I'd like to fix this issue. ### Modifications * Use same regex code between boost and std like [this](https://github.com/apache/pulsar/pull/9533/files#diff-a67e917f5f42f3337507a69a4e0f13e286238dc759b4048cb5141290cf445b38) * Fix regex to be able to capture relative path like `file:./` (cherry picked from commit 7cce8e3)
gaoran10
added a commit
to gaoran10/pulsar
that referenced
this pull request
Sep 10, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Dec 11, 2021
* [C++] Removed usages of boost::regex * Fixed formatting * Fixed test * Fixed formatting (cherry picked from commit 8d0c36e)
BewareMyPower
added a commit
that referenced
this pull request
Dec 11, 2021
This reverts commit 6332787.
BewareMyPower
pushed a commit
that referenced
this pull request
Dec 11, 2021
* [C++] Removed usages of boost::regex * Fixed formatting * Fixed test * Fixed formatting
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation apache#9533 causes some degraded behaviors at [ZTSClient](https://github.com/apache/pulsar/pull/9533/files#diff-41a90a5ec7937b5e2151752843621d6acfe8963077dc04c285842a09a4e45ecc). 1. when using boost::regex - can't set `path` at file scheme 2. when using std::regex - can't set relative path like `file:./path/to/private.key` I'd like to fix this issue. ### Modifications * Use same regex code between boost and std like [this](https://github.com/apache/pulsar/pull/9533/files#diff-a67e917f5f42f3337507a69a4e0f13e286238dc759b4048cb5141290cf445b38) * Fix regex to be able to capture relative path like `file:./`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remove boost::regex which is the only remaining runtime boost dependency.
Changes
Removed the usage of
boost::regex, substituting withstd::regex. We only need to use boost::regex with old gcc versions that have buggy implementation of regexes. In particular, this happens with G++ 4.8.2 which is the one used when buildingmanylinux1Python wheel files.