Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add producer metrics for Prometheus #9541

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Add producer metrics for Prometheus #9541

merged 2 commits into from
Feb 17, 2021

Conversation

wangjialing218
Copy link
Contributor

Motivation

There are subscriptions and consumers metrics for prometheus but miss producers' metrics.

Modifications

  1. Add producer metrics for prometheus.
  2. Add a configration for whether export producer metrics, default is false.

Verifying this change

Add test case testPerProducerStats() in PrometheusMetricsTest

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API: ( no)
  • The schema: ( no)
  • The default values of configurations: ( no)
  • The wire protocol: ( no)
  • The rest endpoints: ( no)
  • The admin cli options: ( no)
  • Anything that affects deployment: ( no)

@sijie sijie added area/metrics type/feature The PR added a new feature or issue requested a new feature labels Feb 9, 2021
@sijie sijie added this to the 2.8.0 milestone Feb 9, 2021
@gaoran10
Copy link
Contributor

gaoran10 commented Feb 9, 2021

/pulsarbot run-failure-checks

@wangjialing218
Copy link
Contributor Author

/pulsarbot run-failure-checks

@sijie sijie merged commit 7bf7cdd into apache:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

Assignees

@wangjialing218 wangjialing218

Labels
area/metrics type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wangjialing218 @gaoran10 @sijie @zymap