[Functions] Close InputStreams properly #9568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Feb 12, 2021
|
@zymap Can you review this? |
|
/pulsarbot run-failure-checks |
lhotari
force-pushed
the
lh-close-streams-in-function-downloads
branch
from
8a5c3e9
to
fed1b30
Compare
|
I found a few more InputStream leaks. I was focusing on Pulsar Functions upload/download related streams, but I happened to find a few others when I did a quick search. |
merlimat
approved these changes
Feb 12, 2021
aahmed-se
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
InputStreams should always be closed properly. There were a few locations related to function
upload/download where streams weren't closed. This PR also fixes other locations which showed up to not close InputStreams properly.
Modifications
try-with-resources block is used to handle an InputStream