Fix writing/encoding of GenericJsonRecord #9608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarvinCai
reviewed
Feb 17, 2021
| @@ -36,7 +38,11 @@ public GenericJsonWriter() { | |||
| @Override | |||
| public byte[] write(GenericRecord message) { | |||
| try { | |||
| return objectMapper.writeValueAsBytes(((GenericJsonRecord)message).getJsonNode().toString()); | |||
| ByteArrayOutputStream buffer = new ByteArrayOutputStream(); | |||
There was a problem hiding this comment.
I wonder if there's any specific reason we want to create our own ByteArrayOutputStream & JsonGenerator, which is what objectMapper.writeValueAsBytes() is doing internally, instead it is using a ByteArrayBuilder which is basically Jackson's implementation of OutputStream and claim to be more efficient in many of its use case.
I think we should just use objectMapper.writeValueAsBytes() unless we want to write output to somewhere else(not a byte[]).
There was a problem hiding this comment.
@MarvinCai thanks for the heads up. I was overdoing it. :) I pushed a fix where I simply dropped .toString(), as you had already pointed out in the issue report.
lhotari
force-pushed
the
lh-fix-genericjsonwriter
branch
from
1e1fcc8
to
4816f73
Compare
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Feb 19, 2021
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 20, 2021
* Fix writing/encoding of GenericJsonRecord - Fixes apache#9605 * Add test for JSONSchema encode/decode round-trip (cherry picked from commit 41e118a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9605
Motivation
See #9605
Modifications
JsonNodeobject directly to Jackson's ObjectMapper.writeValueAsBytes method instead of calling.toString()on theJsonNodevalue.