-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include pulsar-client-admin-api in the shaded version of pulsar-client-admin #9689
Include pulsar-client-admin-api in the shaded version of pulsar-client-admin #9689
Conversation
@@ -66,6 +66,7 @@ | |||
<include>org.apache.pulsar:pulsar-client-original</include> | |||
<include>org.apache.pulsar:pulsar-client-api</include> | |||
<include>org.apache.pulsar:pulsar-client-admin-original</include> | |||
<include>org.apache.pulsar:pulsar-client-admin-api</include> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically, the API module should be left out of the shaded jar, instead being a transitive dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@merlimat pulsar-client-api
is included as well. The problem is with shading. If pulsar-client-admin-api is not included in the shaded JAR and is just pull in as a transitive dependency errors like
java.lang.NoSuchMethodError: org.apache.pulsar.client.admin.PulsarAdminException.<init>(Lorg/apache/pulsar/shade/javax/ws/rs/ClientErrorException;)V
will occur because the impl will be using the shaded version classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @jerrypeng
we already have org.apache.pulsar:pulsar-client-api
is it an error ?
@freeznet Can you review this? I think this is related to one task you are working on. |
@@ -66,6 +66,7 @@ | |||
<include>org.apache.pulsar:pulsar-client-original</include> | |||
<include>org.apache.pulsar:pulsar-client-api</include> | |||
<include>org.apache.pulsar:pulsar-client-admin-original</include> | |||
<include>org.apache.pulsar:pulsar-client-admin-api</include> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @jerrypeng
we already have org.apache.pulsar:pulsar-client-api
is it an error ?
…t-admin (apache#9689) Co-authored-by: Jerry Peng <jerryp@splunk.com>
In the following PR:
#9246
The API of the pulsar-client-admin was separated into another module. However, the api module was not added to be included in the shaded version of pulsar-client-admin. This creates dependency issues such as
java.lang.NoSuchMethodError: org.apache.pulsar.client.admin.PulsarAdminException.<init>(Lorg/apache/pulsar/shade/javax/ws/rs/ClientErrorException;)V