Fix exception when force delete namespace #9691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murong00
approved these changes
Feb 24, 2021
|
/pulsarbot run-failure-checks |
BewareMyPower
approved these changes
Feb 24, 2021
|
/pulsarbot run-failure-checks |
315157973
approved these changes
Mar 1, 2021
wangjialing218
force-pushed
the
branch-fix-force_delete_namespace
branch
from
7fdef24
to
35ded6e
Compare
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Mar 3, 2021
mlyahmed
pushed a commit
to mlyahmed/pulsar
that referenced
this pull request
Mar 5, 2021
When force delete namespace, the partition topics to be deleted are list twice and a exception will happen when delete the topic second time. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When force delete namespace, the partition topics to be deleted are list twice and a exception will happen when delete the topic second time.
Modifications
Correct the list of topics under the namespace to be delete.
Verifying this change
This change is already covered by existing tests, such as testForceDeleteNamespace()