[Issue 9725][Transaction] - Fix deleteTransactionMarker memory leak #9751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2021
eolivelli
approved these changes
Feb 28, 2021
codelipenghui
approved these changes
Feb 28, 2021
|
@congbobo184 Could you please help review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (part of) #9725 (not sure if there are other leaks, though)
Motivation
Fixes a memory leak for transactions.
Modifications
The
ReadEntryCallbackshould release theentrypassed to it. I validated that other implementations of theReadEntryCallbackclass release theentry. Further, the final stack trace referenced in #9725 has clear references to this stack. The only change is to callentry.release(). Because parsing could lead to an exception, I used afinallyblock.Verifying this change
This change is a trivial rework / code cleanup without any test coverage. (We must not have test coverage for this type of leak, though.)
Cherry Pick
This PR fixes a memory leak in master (that is also in 2.7.0). We'll want to make sure this makes it into the
2.7.1release.