[Issue 9173] [Non Persistent Topics] Auto-create partitions even when the auto-creation is disabled #9786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested changes
Mar 4, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
codelipenghui
added
type/bug
mlyahmed
commented
Mar 4, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
mlyahmed
force-pushed
the
issue-9173
branch
2 times, most recently
from
f9c6f3d
to
b8bc3c7
Compare
… the auto-creation is disabled
codelipenghui
approved these changes
Mar 5, 2021
codelipenghui
requested review from
sijie,
315157973,
hangc0276,
jiazhai,
merlimat,
wolfstudy and
zymap
sijie
approved these changes
Mar 8, 2021
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
pushed a commit
that referenced
this pull request
Mar 23, 2021
… the auto-creation is disabled (#9786) Related to #9173 Master Issue: #9173 ### Motivation Please see #9173 ### Modifications When the BrokerService is about to create a non-persistent topic it checks if it is a partition and if so, even the auto-creation is disabled, it creates it. (cherry picked from commit a19dc65)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9173
Master Issue: #9173
Motivation
Please see #9173
Modifications
When the BrokerService is about to create a non-persistent topic it checks if it is a partition and if so, even the auto-creation is disabled, it creates it.
Verifying this change
Make sure that the change passes the CI checks.
An integration test is added assuring the new behavior
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation