Remove Deb package from pulsar docker image #9811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahmed-se
approved these changes
Mar 5, 2021
aahmed-se
approved these changes
Mar 5, 2021
mlyahmed
pushed a commit
to mlyahmed/pulsar
that referenced
this pull request
Mar 7, 2021
* Remove Deb package from pulsar docker image * There's no more need to remove the .a file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're currently building the Deb pkg for the pulsar c++ client lib and including it in the Docker image.
This was initially done in order to support Go Pulsar functions out of the box, since the Go client lib was based on CGo and it required the C++ client library.
Since we're using the native Go client library, the Deb package it's no longer required and should be removed.