[Issue 9804] Allow to enable or disable the cursor metrics #9814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@limingnihao Please help review this PR, thanks. |
murong00
requested changes
Mar 5, 2021
| // generate managedCursor metrics | ||
| parseMetricsToPrometheusMetrics(new ManagedCursorMetrics(pulsar).generate(), | ||
| clusterName, Collector.Type.GAUGE, stream); | ||
| if(includeManagedCursorMetrics){ |
There was a problem hiding this comment.
Why not use pulsar.getConfiguration().isExposeManagedCursorMetricsInPrometheus() here? BTW, please note the code style if (...) {}.
There was a problem hiding this comment.
Just for being consistent with includeConsumerMetrics, includeProducerMetrics etc.
limingnihao
approved these changes
Mar 6, 2021
MarvinCai
approved these changes
Mar 6, 2021
|
/pulsarbot run-failure-checks |
eolivelli
requested changes
Mar 6, 2021
… and fix code style
codelipenghui
approved these changes
Mar 8, 2021
|
@murong00 Could you please review this PR again? |
murong00
approved these changes
Mar 8, 2021
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9804
Motivation
Allow to enable or disable the cursor metrics
Modifications
add config item
exposeManagedCursorMetricsInPrometheusto allow user to enable or disable the cursor metricsVerifying this change