Log stacktraces of threads that failed to terminate on shutdown within timeout in ExecutorProvider #9840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2021 15:56
…n timeout in ExecutorProvider
merlimat
reviewed
Mar 9, 2021
| @@ -71,7 +75,9 @@ public void shutdownNow() { | |||
| executors.forEach(executor -> { | |||
| executor.shutdownNow(); | |||
| try { | |||
| executor.awaitTermination(10, TimeUnit.SECONDS); | |||
| if(!executor.awaitTermination(10, TimeUnit.SECONDS)) { | |||
| log.error("Failed to terminate executor with pool name {} within timeout. The following are stack traces of still running threads.\n{}", poolName, getThreadDump()); | |||
merlimat
reviewed
Mar 9, 2021
| @@ -791,7 +791,7 @@ private static EventLoopGroup getEventLoopGroup(ClientConfigurationData conf) { | |||
| return EventLoopUtil.newEventLoopGroup(conf.getNumIoThreads(), threadFactory); | |||
| } | |||
|
|
|||
| private static ThreadFactory getThreadFactory(String poolName) { | |||
| public static ThreadFactory getThreadFactory(String poolName) { | |||
There was a problem hiding this comment.
Actually, it makes more sense to just move this static method over to the other class.
There was a problem hiding this comment.
changed not needed anymore
added 2 commits
March 8, 2021 17:20
merlimat
reviewed
Mar 9, 2021
| import static com.google.common.base.Preconditions.checkNotNull; | ||
| import com.google.common.collect.Lists; | ||
| import io.netty.util.concurrent.DefaultThreadFactory; | ||
| import javafx.util.Pair; |
There was a problem hiding this comment.
Do not use javafx import, rather commons.lang3.
merlimat
approved these changes
Mar 9, 2021
codelipenghui
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Log stacktraces of threads that failed to terminate on shutdown within timeout in ExecutorProvider so that we have more insights on where threads are getting stuck especially for message listener threads that run user code.
Example of output when an executor failed to shutdown within timeout