Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pulsar SQL]support protobuf_native decoder #9841

Merged
merged 7 commits into from
Mar 12, 2021
Merged

[Pulsar SQL]support protobuf_native decoder #9841

merged 7 commits into from
Mar 12, 2021

Conversation

hnail
Copy link
Contributor

@hnail hnail commented Mar 9, 2021

Fixes #3554

Motivation

Pulsar SQL support for Protobuf.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no )
  • The public API: (no)
  • The schema: ( no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

@codelipenghui
Copy link
Contributor

@gaoran10 @congbobo184 Please help review this PR.

@codelipenghui codelipenghui added area/sql Pulsar SQL related features type/feature The PR added a new feature or issue requested a new feature labels Mar 9, 2021
@codelipenghui codelipenghui added this to the 2.8.0 milestone Mar 9, 2021
@hnail
Copy link
Contributor Author

hnail commented Mar 9, 2021

/pulsarbot run-failure-checks

@merlimat merlimat requested a review from jerrypeng March 9, 2021 16:56
gaoran10
gaoran10 reviewed Mar 10, 2021
View reviewed changes
Copy link
Contributor

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, LGTM, left some trivial suggestions.

Could you add an integration test for the SchemaType.PROTOBUF_NATIVE, please refer to the method testForSchema of the class TestBasicPresto.

...java/org/apache/pulsar/sql/presto/decoder/protobufnative/PulsarProtobufNativeRowDecoder.java Outdated Show resolved Hide resolved
...a/org/apache/pulsar/sql/presto/decoder/protobufnative/PulsarProtobufNativeColumnDecoder.java Show resolved Hide resolved
...a/org/apache/pulsar/sql/presto/decoder/protobufnative/PulsarProtobufNativeColumnDecoder.java Outdated Show resolved Hide resolved
@hnail
Copy link
Contributor Author

hnail commented Mar 10, 2021

/pulsarbot run-failure-checks

congbobo184
congbobo184 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@congbobo184 congbobo184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All over look good!

...g/apache/pulsar/sql/presto/decoder/protobufnative/PulsarProtobufNativeRowDecoderFactory.java Show resolved Hide resolved
...a/org/apache/pulsar/sql/presto/decoder/protobufnative/PulsarProtobufNativeColumnDecoder.java Outdated Show resolved Hide resolved
codelipenghui
codelipenghui reviewed Mar 11, 2021
View reviewed changes
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hnail The change looks good to me, could you please help add an integration test for using Pulsar SQL to queue data with protobuf_native schema?

@hnail hnail changed the title [SQL]support protobuf_native decoder [Pulsar SQL]support protobuf_native decoder Mar 11, 2021
@hnail
Copy link
Contributor Author

hnail commented Mar 11, 2021

/pulsarbot run-failure-checks

@sijie sijie merged commit eb972a6 into apache:master Mar 12, 2021
@hnail hnail deleted the sql_support_protobuf_decoder branch March 14, 2021 10:32
fmiguelez pushed a commit to fmiguelez/pulsar that referenced this pull request Mar 16, 2021
@hnail
[Pulsar SQL]support protobuf_native decoder (apache#9841)
a0ee17a 
Fixes apache#3554 

### Motivation

Pulsar SQL support for Protobuf.
@imaffe imaffe mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoran10 gaoran10 gaoran10 left review comments

@sijie sijie sijie approved these changes

@eolivelli eolivelli eolivelli approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@congbobo184 congbobo184 congbobo184 approved these changes

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@jiazhai jiazhai Awaiting requested review from jiazhai

@merlimat merlimat Awaiting requested review from merlimat

@315157973 315157973 Awaiting requested review from 315157973

@hangc0276 hangc0276 Awaiting requested review from hangc0276

@zymap zymap Awaiting requested review from zymap

Assignees

@hnail hnail

Labels
area/sql Pulsar SQL related features type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Pulsar SQL support for Protobuf
6 participants
@hnail @codelipenghui @sijie @eolivelli @gaoran10 @congbobo184