Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ensure single-topic consumer can be closed #9849

Merged
merged 2 commits into from Mar 11, 2021
Merged

Fix ensure single-topic consumer can be closed #9849

merged 2 commits into from Mar 11, 2021

Conversation

HugeSkull
Copy link
Contributor

It is found that there is a logic problem in creating a consumer, which may cause the consumer to be unable to close

codelipenghui
codelipenghui reviewed Mar 9, 2021
View reviewed changes
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, could you please help add a unit test to cover this case to avoid regression?

@codelipenghui codelipenghui added type/bug The PR fixed a bug or issue reported a bug area/client labels Mar 9, 2021
@codelipenghui codelipenghui added this to the 2.8.0 milestone Mar 9, 2021
@HugeSkull
Copy link
Contributor Author

Of course, I have added the unit test, please take a look @codelipenghui

@HugeSkull HugeSkull force-pushed the fix/create-single-topic-subscribe branch from 7c75543 to 8314c2e Compare March 10, 2021 02:17
315157973
315157973 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@315157973 315157973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@HugeSkull
Copy link
Contributor Author

All checks have passed. Can this PR be merged? @codelipenghui @315157973

@315157973 315157973 merged commit 1cd8658 into apache:master Mar 11, 2021
@HugeSkull HugeSkull deleted the fix/create-single-topic-subscribe branch March 11, 2021 12:40
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Mar 23, 2021
codelipenghui pushed a commit that referenced this pull request Mar 23, 2021
@HugeSkull @codelipenghui
Fix ensure single-topic consumer can be closed (#9849)
b26e07e 
It is found that there is a logic problem in creating a consumer, which may cause the consumer to be unable to close

(cherry picked from commit 1cd8658)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@315157973 315157973 315157973 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@hangc0276 hangc0276 Awaiting requested review from hangc0276

@jiazhai jiazhai Awaiting requested review from jiazhai

@merlimat merlimat Awaiting requested review from merlimat

@sijie sijie Awaiting requested review from sijie

@zymap zymap Awaiting requested review from zymap

Assignees

@HugeSkull HugeSkull

Labels
area/client cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.2 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HugeSkull @315157973 @codelipenghui