[Metrics] Add the broker connection metrics. #9876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@congbobo184 thanks for your work. Would you like to add docs accordingly? Then we can help review, thanks |
|
@Anonymitaet Ok I will add the doc. |
merlimat
reviewed
Mar 12, 2021
| @@ -34,6 +35,11 @@ | |||
| private final DimensionStats zkWriteLatencyStats; | |||
| private final DimensionStats zkReadLatencyStats; | |||
| private final String brokerName; | |||
| private final AtomicLong connectionTotalCreatedCount; | |||
There was a problem hiding this comment.
Prefer LongAdder instead of AtomicLong since it will have less contention issues.
There was a problem hiding this comment.
OK i will change the atomicLong to LongAdder.
codelipenghui
approved these changes
Mar 14, 2021
|
/pulsarbot run-failure-checks |
codelipenghui
requested review from
sijie,
315157973,
hangc0276,
jiazhai and
zymap
Anonymitaet
reviewed
Mar 15, 2021
Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
fmiguelez
pushed a commit
to fmiguelez/pulsar
that referenced
this pull request
Mar 16, 2021
## Motivation Add the broker connection metrics. ## implement add metrics ``` brk_connection_created_total_count brk_connection_create_success_count brk_connection_create_fail_count brk_connection_closed_total_count brk_active_connections ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add the broker connection metrics.
implement
add metrics
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)