Support get persistent topics or non-persistent topics for pulsar admin client #9877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
added
type/feature
codelipenghui
added
type/enhancement
codelipenghui
requested review from
sijie,
315157973,
merlimat,
hangc0276,
jiazhai,
zymap and
murong00
315157973
reviewed
Mar 11, 2021
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
Outdated
Show resolved
Hide resolved
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/GetTopicsMode.java
Outdated
Show resolved
Hide resolved
315157973
approved these changes
Mar 11, 2021
|
@codelipenghui yes, it will be generated automatically from the code file. We can double check whether it's displayed on the admin website after merging the PR and triggering the website. |
eolivelli
requested changes
Apr 9, 2021
branch_delete_except.sh
Outdated
| @@ -0,0 +1,7 @@ | |||
| #!/bin/bash | |||
|
|
|||
| for branch in `git branch`; do | |||
There was a problem hiding this comment.
It looks like this file is not related to this patch, please remove
There was a problem hiding this comment.
Oh, my mistake.
|
@codelipenghui this is a new REST API, do you really want to pick it to 2.7.2 ? |
|
@eolivelli removed 2.7.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, we can only get all topics by the admin client. This pr supports to get persistent topic or non-persistent topic by add
--topic-domain=persistentor--topic-domain=non-persistent.For Pulsar SQL, is should only get fetch the persistent topics when list tables. I will push the next PR to fix the pulsar SQL.
Verifying this change
Unit test and integration test added.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
The document for the admin API is generated automatically, @jennifer88huang please double confirm.