[WebSocket Client] Make the browser client support the token authentication #9886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
zymap
reviewed
Mar 12, 2021
There is already a mock broker test, I could add a real token case for it. |
|
@tuteng Can you take a look at this PR? |
codelipenghui
approved these changes
Mar 14, 2021
fmiguelez
pushed a commit
to fmiguelez/pulsar
that referenced
this pull request
Mar 16, 2021
…cation (apache#9886) Fixes issue apache#9854 ### Motivation Currently, the WebSocket client uses the HTTP request header to transport the authentication params, but the browser javascript WebSocket client couldn't add new headers. ### Modifications Use the query param `token` to transport the authentication token for the browser javascript WebSocket client.
|
@codelipenghui Can you make sure this change is cherry-picked to 2.7.2? |
|
ok |
codelipenghui
added
cherry-picked/branch-2.7
codelipenghui
pushed a commit
that referenced
this pull request
Mar 24, 2021
…cation (#9886) Fixes issue #9854 ### Motivation Currently, the WebSocket client uses the HTTP request header to transport the authentication params, but the browser javascript WebSocket client couldn't add new headers. ### Modifications Use the query param `token` to transport the authentication token for the browser javascript WebSocket client. (cherry picked from commit f1f272e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #9854
Motivation
Currently, the WebSocket client uses the HTTP request header to transport the authentication params, but the browser javascript WebSocket client couldn't add new headers.
Modifications
Use the query param
tokento transport the authentication token for the browser javascript WebSocket client.Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Update the WebSocket client document.