More fixes about running tests on JDK11 #9893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
merlimat
reviewed
Mar 12, 2021
merlimat
approved these changes
Mar 12, 2021
|
@merlimat I have addressed your comments PTAL |
sijie
approved these changes
Mar 12, 2021
codelipenghui
approved these changes
Mar 14, 2021
fmiguelez
pushed a commit
to fmiguelez/pulsar
that referenced
this pull request
Mar 16, 2021
### Motivation When you are running tests on JDK11 you encounter a lot of issues. This patch includes a list of minor fixes that can be grouped. Master issue apache#9578 ### Modifications - Upgrade Mockito to latest version - Add "--add-opens java.base/jdk.internal.loader=ALL-UNNAMED" in order to allow PowerMock to work - add JAXB into jcloud provider (we already have it on the classpath in production, it is only in order to let tests run) - Upgrade HDFS minicluster to 3.3.0 - Pin netty-codec-http dependency to the same version of netty (inherited from HDFS client) - Use the same version of Jetty for hdfs-offload (old version does not work with JDK11)
|
Hi, I just pull the latest master and when I ran a test with Intellij Idea, it failed to start with following error message I think it may be caused by this PR. <profile>
<id>jdk11-tests</id>
<activation>
<jdk>[11,)</jdk>
</activation>
<properties>
<test.additional.args> --add-opens java.base/jdk.internal.loader=ALL-UNNAMED </test.additional.args>
</properties>
</profile>But even after I removed these lines from |
|
In IntelliJ check if it automatically enabled this profile. If so then simply unselect it. @BewareMyPower we can continue on slack |
|
Thanks for you advice. I found the real cause just now, which is not related to this profile. The error may be caused by some Maven plugins, see https://youtrack.jetbrains.com/issue/IDEA-258574 I just fixed it by disabling the
|
eolivelli
added a commit
to datastax/pulsar
that referenced
this pull request
May 10, 2021
When you are running tests on JDK11 you encounter a lot of issues. This patch includes a list of minor fixes that can be grouped. Master issue apache#9578 - Upgrade Mockito to latest version - Add "--add-opens java.base/jdk.internal.loader=ALL-UNNAMED" in order to allow PowerMock to work - add JAXB into jcloud provider (we already have it on the classpath in production, it is only in order to let tests run) - Upgrade HDFS minicluster to 3.3.0 - Pin netty-codec-http dependency to the same version of netty (inherited from HDFS client) - Use the same version of Jetty for hdfs-offload (old version does not work with JDK11)
eolivelli
added a commit
to datastax/pulsar
that referenced
this pull request
May 11, 2021
When you are running tests on JDK11 you encounter a lot of issues. This patch includes a list of minor fixes that can be grouped. Master issue apache#9578 - Upgrade Mockito to latest version - Add "--add-opens java.base/jdk.internal.loader=ALL-UNNAMED" in order to allow PowerMock to work - add JAXB into jcloud provider (we already have it on the classpath in production, it is only in order to let tests run) - Upgrade HDFS minicluster to 3.3.0 - Pin netty-codec-http dependency to the same version of netty (inherited from HDFS client) - Use the same version of Jetty for hdfs-offload (old version does not work with JDK11)
eolivelli
added a commit
to datastax/pulsar
that referenced
this pull request
May 20, 2021
### Motivation
When you are running tests on JDK11 you encounter a lot of issues.
This patch includes a list of minor fixes that can be grouped.
Master issue apache#9578
### Modifications
- Upgrade Mockito to latest version
- Add "--add-opens java.base/jdk.internal.loader=ALL-UNNAMED" in order to allow PowerMock to work
- add JAXB into jcloud provider (we already have it on the classpath in production, it is only in order to let tests run)
- Upgrade HDFS minicluster to 3.3.0
- Pin netty-codec-http dependency to the same version of netty (inherited from HDFS client)
- Use the same version of Jetty for hdfs-offload (old version does not work with JDK11)
cherry picked manually from c94d782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When you are running tests on JDK11 you encounter a lot of issues.
This patch includes a list of minor fixes that can be grouped.
Master issue #9578
Modifications
Verifying this change
Tests must still run successfully on JDK8.
Once all tests are known to run on JDK11 we will switch CI tests runner to JDK11, this cannot be done in this PR.