[Transaction] Transaction buffer clear abort transactions #9974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Mar 22, 2021
eolivelli
reviewed
Mar 22, 2021
| @@ -322,8 +322,12 @@ private void takeSnapshot() { | |||
| }); | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
| private void clearAbortTransaction() { | |||
There was a problem hiding this comment.
What about 'clearAbortedTransactions' ?
There was a problem hiding this comment.
good suggestion
|
|
||
|
|
||
| private void clearAbortTransaction() { | ||
| while (!aborts.isEmpty() && !((ManagedLedgerImpl) topic.getManagedLedger()) |
There was a problem hiding this comment.
IIRC there is an ongoing effort to not use ManafedLedgerImpl but only the interface.
Is it necessary to do this cast?
There was a problem hiding this comment.
ledgerExists it is not the ManagedLedger interface method.
| private void clearAbortTransaction() { | ||
| while (!aborts.isEmpty() && !((ManagedLedgerImpl) topic.getManagedLedger()) | ||
| .ledgerExists(aborts.get(aborts.firstKey()).getLedgerId())) { | ||
| aborts.remove(aborts.firstKey()); |
There was a problem hiding this comment.
Should be log the txid of the transactions that we are clearing?
There was a problem hiding this comment.
good, i will add the debug level log for clear aborted transaction.
sijie
approved these changes
Mar 22, 2021
|
/pulsarbot run-failure-checks |
added 2 commits
March 23, 2021 19:12
|
/pulsarbot run-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Transaction buffer clear abort transactions.
implement
check the aborts position's ledgerId whether exist in topic
ManagedLedgerImplledgers.Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)