[Performance] Optimize NamespaceBundle.toString() which is on the hot path #9976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… path - This is on the hot path of ownership checks for topics - also optimize getBundleRange() although the method doesn't seem to be on hot paths - it's more consistent with the change for toString() in NamespaceBundle class
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
rdhabalia
approved these changes
Mar 19, 2021
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
merlimat
added
the
type/enhancement
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Mar 22, 2021
… path (apache#9976) - This is on the hot path of ownership checks for topics - also optimize getBundleRange() although the method doesn't seem to be on hot paths - it's more consistent with the change for toString() in NamespaceBundle class
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is on the hot path of ownership checks for topics
also optimize getBundleRange() although the method doesn't seem to be on hot paths
Modifications
Add final fields for pre-calculating the values returned by toString and getBundleRange methods