Fix NPE caused by null value of SchemaInfo's properties #9985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've pushed a PR to fix your issue. But I'm curious about why did you set a property value to |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
jianyun8023
reviewed
Mar 20, 2021
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Mar 22, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Mar 22, 2021
Fixes apache#9964 ### Motivation If there exists a null value of `SchemaInfo`'s properties, NPE will be thrown in `SchemaInfo#toString` or `Commands#newSubscribe`. ### Modifications - Add null checks before `JsonPrimitive`'s constructor, `KeyValue#setKey` and `KeyValue#setValue`. - Add related tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9964
Motivation
If there exists a null value of
SchemaInfo's properties, NPE will be thrown inSchemaInfo#toStringorCommands#newSubscribe.Modifications
JsonPrimitive's constructor,KeyValue#setKeyandKeyValue#setValue.Verifying this change
This change added tests and can be verified as follows:
SchemaTest#testNullKeyValuePropertyandSchemaInfoTest#testNullPropertyValue.