Fix the useless retry when the maximum number of subscriptions is reached #9991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Mar 22, 2021
codelipenghui
approved these changes
Mar 22, 2021
|
@315157973 Sorry, could you please help add a test to avoid the regression? |
codelipenghui
requested review from
eolivelli,
sijie,
hangc0276,
jiazhai,
merlimat and
zymap
codelipenghui
added
release/2.7.2
type/bug
jiazhai
approved these changes
Mar 22, 2021
sijie
approved these changes
Mar 23, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Mar 24, 2021
…ched (#9991) When the maximum number of subscriptions is reached, due to the long default value of operationTimeout, the client will keep retrying and get stuck for a long time. If a NotAllowedException is returned, the client will not continue to retry and will fail directly. Can the test fail in a short time (cherry picked from commit 31c5fb5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the maximum number of subscriptions is reached, due to the long default value of operationTimeout, the client will keep retrying and get stuck for a long time.
If a NotAllowedException is returned, the client will not continue to retry and will fail directly.
Test
Can the test fail in a short time